Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FakePrague Egret R1 to fake backends #9369

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Add FakePrague Egret R1 to fake backends #9369

merged 6 commits into from
Jan 13, 2023

Conversation

nonhermitian
Copy link
Contributor

Summary

Adds the Prague device to the fake backends

Details and comments

Pulse defaults is not included as there is an error importing them. However, this adds a new system with cz entangling gates, and thus is a nice addition to the fake backends.

@nonhermitian nonhermitian requested review from a team and jyu00 as code owners January 12, 2023 20:43
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

mtreinish
mtreinish reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, before I approve though can you add FakePrague to the list of backends in FakeProviderForBackendV2 in qiskit/providers/fake_provider/fake_provider.py. That will use it in the test suite to validate everything works with it. Also we've been adding the fake backends off of qiskit/provider/fake_provider/__init__.py and including them in the autosummary for the docs.

releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml Outdated Show resolved Hide resolved
@nonhermitian
Copy link
Contributor Author

Ok, hopefully that addresses those issues.

@mtreinish mtreinish added Changelog: New Feature Include in the "Added" section of the changelog mod: fake_provider Related to the fake_provider module and fake backends labels Jan 12, 2023
@mtreinish mtreinish added this to the 0.23.0 milestone Jan 12, 2023
mtreinish
mtreinish approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick updates.

@jakelishman
Copy link
Member

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2023

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 53be473 into Qiskit:main Jan 13, 2023
@nonhermitian nonhermitian mentioned this pull request Jan 13, 2023
Open
ElePT pushed a commit to ElePT/qiskit-ibm-provider that referenced this pull request Oct 4, 2023
@nonhermitian @mtreinish @mergify
Add FakePrague Egret R1 to fake backends (Qiskit/qiskit#9369)
e3d1a69 
* Add FakePrague device

* Add release note

* Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml

Co-authored-by: Matthew Treinish <[email protected]>

* Add suggestions

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Oct 10, 2023
@nonhermitian @mtreinish @mergify
Add FakePrague Egret R1 to fake backends (Qiskit/qiskit#9369)
2b0205a 
* Add FakePrague device

* Add release note

* Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml

Co-authored-by: Matthew Treinish <[email protected]>

* Add suggestions

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit that referenced this pull request Oct 12, 2023
@nonhermitian @mtreinish @mergify
Add FakePrague Egret R1 to fake backends (Qiskit#9369)
6533480 
* Add FakePrague device

* Add release note

* Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml

Co-authored-by: Matthew Treinish <[email protected]>

* Add suggestions

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
ElePT pushed a commit to ElePT/qiskit-ibm-runtime that referenced this pull request Dec 8, 2023
@nonhermitian @mtreinish @mergify
Add FakePrague Egret R1 to fake backends (Qiskit/qiskit#9369)
efa7a36 
* Add FakePrague device

* Add release note

* Update releasenotes/notes/add_fake_prague-79f82b83c2e2329c.yaml

Co-authored-by: Matthew Treinish <[email protected]>

* Add suggestions

Co-authored-by: Matthew Treinish <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

@jyu00 jyu00 Awaiting requested review from jyu00 jyu00 is a code owner

Assignees
No one assigned
Labels
Changelog: New Feature Include in the "Added" section of the changelog mod: fake_provider Related to the fake_provider module and fake backends
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nonhermitian @qiskit-bot @jakelishman @mtreinish